Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CustomID to UploadImageParams #3262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilpriver
Copy link

Description

I added support for CustomID when we upload images to Cloudflare images which I hope is supported by CF API: https://developers.cloudflare.com/images/upload-images/upload-custom-path/

Please correct me if I'm wrong but Custom ID means that we can select which ID to have for the image right?

Has your change been tested?

Yes. I tested this in my own app and seems to be working

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@emilpriver
Copy link
Author

The reason for the failed CI is

go: downloading golang.org/x/exp/typeparams v0.0.0-20221212164502-fae10dda9338
go: golang.org/x/tools/cmd/goimports@latest (in golang.org/x/tools@v0.25.0): go.mod:3: invalid go version '1.22.0': must match format 1.23
internal/tools/tools.go:22: running "go": exit status 1

Do you want me to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant