Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitingRoom.CookieAttributes property #3388

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

jorygeerts
Copy link
Contributor

Description

Add the WaitingRoom.CookieAttributes property.

Note that this property is mentioned in the API docs and in some guidelines (eg Waiting Room / Additional options / Embed in an iFrame, but is not available via dash.cloudflare.com (which is mentioned in the iFrame guide).

This property is also supported in the Python and Typescript SDKs.

Has your change been tested?

I've tested this locally by setting this property do non-default values in the input for the CreateWaitingRoom() and UpdateWaitingRoom() calls, and then observing that ListWaitingRooms() returns the correct values.

I haven't added automated tests, because there is no logic change. All a unit test would prove is that the name of the property can be copy-pasted from the Go tag into a unittest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

waiting_room.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit e2a1fae into cloudflare:master Oct 16, 2024
7 of 9 checks passed
@github-actions github-actions bot added this to the v0.108.0 milestone Oct 16, 2024
Copy link
Contributor

This functionality has been released in v0.108.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants