replace unmaintained safemem::copy_over with slice::copy_within #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
requested review from
jongiddy,
Noah-Kennedy,
orium,
scotchmist,
kflansburg,
jasnell and
a team
as code owners
This was referenced Mar 7, 2024
rillian
added a commit
to brave/brave-core
that referenced
this pull request
Mar 7, 2024
Apply syphar's patch from cloudflare/lol-html#208 to address RUSTSEC-2023-0081 about `safemem` being unmaintained. This uses `slice::copy_within`, added in Rust 1.37.0, instead, which performs the same panic-based bounds checks. There should be no behaviour change. The patch is against lol_html v1.2.0, but the code hasn't changed since our v0.3.1.
|
CI failures are unrelated clippy warnings. |
|
Could you please rebase on top of your clippy fix? |
* the `safemem` library is [unmaintained][1] * both `safemem::copy_over` and `slice::copy_within` use `ptr::copy` internally, so the performance impact should me minimal. * `slice::copy_within` was added in rust 1.37.0, but I don't know if lol-html has an official MSRV [1]: https://rustsec.org/advisories/RUSTSEC-2023-0081.html
done |
inikulin
approved these changes
Mar 11, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safememlibrary is unmaintainedsafemem::copy_overandslice::copy_withinuseptr::copyinternally, so the performance impact should be minimal.slice::copy_withinwas added in rust 1.37.0, but I don't know if lol-html has an official MSRV