Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TOML parser to support dotted keys in wrangler.toml #13

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

leaysgur
Copy link
Contributor

Hi. 👋🏻

It seems toml module does not support some TOML features like dotted keys.

BinaryMuse/toml-node#51

For example,

[build]
upload.format = "service-worker"
command = "npm run build"

This ends up with Unable to parse wrangler.toml: SyntaxError: Expected "=", [ \t] or [A-Za-z0-9_\-] but "." found. error now. (Of course this is valid TOML for wrangler CLI.)

And also toml module is not actively maintained, so why not use another implementation? 👀

@mrbbot
Copy link
Contributor

mrbbot commented Jul 17, 2021

Hello! 👋 This looks great, thanks for the PR! 😃 Seems like this package is more popular than toml too. 😅

@mrbbot mrbbot merged commit 341c355 into cloudflare:master Jul 17, 2021
@mrbbot
Copy link
Contributor

mrbbot commented Jul 21, 2021

Version 1.3.0 has just been released, including this change. 🎉 Let me know if you have any problems with it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants