Feature: getMiniflareWaitUntil #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Aug 23, 2022
Comment on lines
248
to
267
| global.getMiniflareWaitUntil = ( | ||
| event: FetchEvent | ScheduledEvent | ||
| ): Promise<unknown>[] => { | ||
| return event[kWaitUntil]; | ||
| }; |
There was a problem hiding this comment.
With the above change, you could replace this with a reference to the getWaitUntil function.
CraigglesO
commented
Aug 23, 2022
| } | ||
|
|
||
| flush<WaitUntil extends any[] = unknown[]>(): Promise<WaitUntil> { | ||
| return Promise.all(this[kWaitUntil]) as Promise<WaitUntil>; |
There was a problem hiding this comment.
Apologies, I might be doing this wrong, but I get an error if I don't explain that any doesn't fall outside unknown.
mrbbot
reviewed
Aug 26, 2022
CraigglesO
force-pushed
the
feature/wait-until
branch
from
00a9466
to
2048eff
Compare
mrbbot
reviewed
Sep 3, 2022
mrbbot
reviewed
Sep 3, 2022
Co-authored-by: CraigglesO <oconnorct1@gmail.com>
mrbbot
force-pushed
the
feature/wait-until
branch
from
098beb9
to
587656a
Compare
|
Hey! 👋 I'm aiming to get a release out today and want to include this. I realised my changes with |
|
My fault for not finishing. Got really busy this week again. Just happy to see this go through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #202
Adds
getMiniflareWaitUntil(event: FetchEvent | ScheduledEvent): Promise<unknown>[];to return an array of promises stored viaevent.waitUntill(...)Example usage for both
FetchEventandScheduledEventcan be found atpackages/jest-environment-miniflare/test/fixtures/waitUntil.worker.spec.js