Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing @miniflare/r2 dependency to shared-test-environment package #394

Merged
merged 1 commit into from
Sep 29, 2022
Merged

fix: Add missing @miniflare/r2 dependency to shared-test-environment package #394

merged 1 commit into from
Sep 29, 2022

Conversation

askoufis
Copy link
Contributor

I believe @miniflare/r2 should be an explicit dependency of shared-test-environment. My guess is that it was accidentally not added because NPM's hoisting resulted in no errors occurring.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✅

@mrbbot mrbbot merged commit 50f3514 into cloudflare:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants