Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dead letter queues #411

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

jbw1991
Copy link
Contributor

@jbw1991 jbw1991 commented Oct 12, 2022

  • Queue broker now respects the configured number of max retries for a consumer
  • Queue broker now respects the configured "dead letter queue". After reaching the max number of attempts, "failed" messages are placed on this queue.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: 36cd45a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✅ Added a couple tiny suggestions but this looks great! 🙂

packages/queues/src/broker.ts Outdated Show resolved Hide resolved
packages/queues/src/broker.ts Outdated Show resolved Hide resolved
@mrbbot mrbbot merged commit 8634653 into cloudflare:master Oct 14, 2022
@a-robinson
Copy link
Member

Hi @mrbbot , any chance we could release this change? Is there much work involved in doing so?

@mrbbot
Copy link
Contributor

mrbbot commented Oct 27, 2022

Yep! 😃 Just waiting for CI to pass on the release (https://github.com/cloudflare/miniflare/actions/runs/3338919123/jobs/5527204221), then will publish. 👍

@a-robinson
Copy link
Member

Thanks! 😃

@mrbbot
Copy link
Contributor

mrbbot commented Oct 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants