Forward cdn-cgi/scripts paths to Cloudflare #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, Miniflare 404s on attempts to download `rocket-loader.min.js`. For folks who've set up a Worker in front of Cloudflare Pages (e.g. to handle API requests on the same domain), this breaks their web app during local development: it renders as a white screen. This PR adds a small amount of logic to simply forward those requests onto Cloudflare.
|
mrbbot
reviewed
Nov 4, 2022
Co-authored-by: MrBBot <me@mrbbot.dev>
|
Thanks for the feedback! I've done as suggested on both :) |
mrbbot
reviewed
Nov 28, 2022
Co-authored-by: MrBBot <me@mrbbot.dev>
Co-authored-by: MrBBot <me@mrbbot.dev>
|
@mrbbot Done! |
mrbbot
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #421.
Right now, Miniflare 404s on attempts to download
rocket-loader.min.js. For folks who've set up a Worker in front of Cloudflare Pages (e.g. to handle API requests on the same domain), this breaks their web app during local development: it renders as a white screen.This PR adds a small amount of logic to simply forward those requests onto Cloudflare.