nodejs_compat flag
#478
Merged
nodejs_compat flag
#478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrbbot
approved these changes
Jan 23, 2023
packages/core/src/plugins/core.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import { Blob } from "buffer"; | |||
| import fs from "fs/promises"; | |||
| import asyncHooks from "node:async_hooks"; | |||
There was a problem hiding this comment.
Looks like this is never used. (I should probably make all eslint rules errors tbh)
GregBrimble
force-pushed
the
nodejs_compat
branch
from
5f526a6
to
867112b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
nodejs_compatflag and attaches thenode:async_hookspartial implementation that is now inworkerd.