Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add https option to have miniflare accept https requests #612

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add https option to have miniflare accept https requests #612

merged 1 commit into from
Jun 27, 2023

Conversation

jspspike
Copy link

No description provided.

@jspspike jspspike requested a review from mrbbot June 20, 2023 20:08
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 09a69af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian
Copy link

gitguardian bot commented Jun 20, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

mrbbot
mrbbot reviewed Jun 22, 2023
View reviewed changes
packages/miniflare/src/http/cert.ts Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Outdated Show resolved Hide resolved
packages/miniflare/src/plugins/core/index.ts Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/https-server branch 4 times, most recently from 713580b to 5d1eba3 Compare June 22, 2023 19:06
@jspspike jspspike requested a review from mrbbot June 22, 2023 19:07
mrbbot
mrbbot reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! It would be nice to see a test of a dispatchFetch() call with the https: true option set in test/index.spec.ts. Ideally, the test would also check the log message for the server starting included the correct protocol too. See here for an test asserting log output.

packages/miniflare/src/index.ts Show resolved Hide resolved
packages/miniflare/src/plugins/core/index.ts Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Show resolved Hide resolved
mrbbot
mrbbot reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KeyPair should be removed from here too:

miniflare/packages/miniflare/src/plugins/index.ts

Line 98 in c86b79a

KeyPair,

packages/miniflare/test/index.spec.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/https-server branch 3 times, most recently from b1b8adf to 9c02d9e Compare June 26, 2023 15:47
@jspspike jspspike requested a review from mrbbot June 26, 2023 15:52
@jspspike jspspike force-pushed the jspspike/https-server branch 2 times, most recently from 98ad945 to 67f1cb7 Compare June 26, 2023 15:59
mrbbot
mrbbot reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor things, then I'll approve 😃

packages/miniflare/src/http/fetch.ts Outdated Show resolved Hide resolved
packages/miniflare/src/http/server.ts Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/https-server branch 5 times, most recently from bba020f to 23bbb65 Compare June 26, 2023 17:53
@jspspike jspspike requested a review from mrbbot June 26, 2023 18:09
@jspspike jspspike force-pushed the jspspike/https-server branch 3 times, most recently from 90a6f6f to d33bc5f Compare June 27, 2023 14:07
mrbbot
mrbbot reviewed Jun 27, 2023
View reviewed changes
.gitguardian.yml Outdated Show resolved Hide resolved
packages/miniflare/src/index.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/https-server branch from d33bc5f to 09a69af Compare June 27, 2023 15:06
@jspspike jspspike requested a review from mrbbot June 27, 2023 15:06
mrbbot
mrbbot approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@jspspike jspspike merged commit 6751442 into tre Jun 27, 2023
@jspspike jspspike deleted the jspspike/https-server branch June 27, 2023 15:59
@mrbbot mrbbot mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspspike @mrbbot