Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare 2] Fix body.cancel() throwing undefined #757

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jahands
Copy link
Contributor

@jahands jahands commented Jan 26, 2024

We noticed while writing a test for code that uses the Cache API that body.cancel() existed, but threw an error complaining that the underlying reader was undefined.

This ensures that reader is set before calling cancel(). I have included a test which failed before but works after the change.

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 828125c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot merged commit c705758 into cloudflare:master Jan 29, 2024
5 of 6 checks passed
@mrbbot
Copy link
Contributor

mrbbot commented Jan 29, 2024

Thanks for fixing this! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants