Fix 32bit x86 build #285
Merged
Fix 32bit x86 build #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ghedo
requested changes
Dec 3, 2019
ghedo
reviewed
Dec 3, 2019
ghedo
force-pushed
the
x86_cross_build
branch
from
10f8fc4 to
8cb4e91
Compare
|
To speed-up merging I addressed the comments myself, we can undo the changes later if needed. |
ghedo
force-pushed
the
x86_cross_build
branch
from
8cb4e91 to
b46615f
Compare
Pass 32bit toolchain to cmake for cross-building x86 linux from x86_64 linux. Also CI target is added. Ref: https://github.com/google/boringssl/blob/master/BUILDING.md Fixes #277.
ghedo
force-pushed
the
x86_cross_build
branch
from
b46615f to
4f6bb7d
Compare
Closed
|
Thanks. Looks like it broke CI which is not caugut on the branch. Created #289 to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass 32bit toolchain to cmake for cross-building x86 linux from
x86_64 linux. Also CI target is added.
Ref: https://github.com/google/boringssl/blob/master/BUILDING.md
Fixes #277