Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal closes on partial click #29

Closed
1000hz opened this issue Aug 21, 2019 · 0 comments · Fixed by #30 or #33
Closed

Modal closes on partial click #29

1000hz opened this issue Aug 21, 2019 · 0 comments · Fixed by #30 or #33

Comments

@1000hz
Copy link
Contributor

1000hz commented Aug 21, 2019

When the user starts a click on the modal and ends it elsewhere (or vice versa) the modal is not prevented from closing. This is not a great experience, since the user might be trying to select text inside of an input or accidentally started their click outside the modal and doesn't intend to actually close it.
@1000hz 1000hz mentioned this issue Aug 21, 2019
Merged
1000hz added a commit to 1000hz/react-modal2 that referenced this issue Aug 21, 2019
@1000hz
prevent modal from closing when modal is partial target of click.
e45e44b 
Fixes cloudflare#29.
1000hz added a commit that referenced this issue Dec 5, 2019
@1000hz
Prevent modal from closing when modal is partial target of click.
55cdb1a 
Fixes #29 (attempt 2)
1000hz added a commit that referenced this issue Dec 5, 2019
@1000hz
Prevent modal from closing when modal is partial target of click.
5215717 
Fixes #29 (attempt 2)
@1000hz 1000hz mentioned this issue Dec 5, 2019
Merged
1000hz added a commit that referenced this issue Dec 9, 2019
@1000hz
Prevent modal from closing when modal is partial target of click.
ff4939a 
Fixes #29 (attempt 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@1000hz