Add primaryColor prop 🎨 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third774
force-pushed
the
primary-color
branch
from
dbaa673 to
bc9292f
Compare
Everlag
approved these changes
Oct 28, 2021
src/types.ts
Outdated
| @@ -64,6 +64,10 @@ export interface StreamPlayerApi { | |||
| * The <video> element does not force the browser to follow the value of this attribute; it is a mere hint. Even though the preload="none" option is a valid HTML5 attribute, Stream player will always load some metadata to initialize the player. The amount of data loaded in this case is negligable. | |||
| */ | |||
| preload: Preload; | |||
| /** | |||
| * Any valid CSS color provided will be applied to certain elements of the player's UI. | |||
There was a problem hiding this comment.
May be useful to include some examples; folks reading this may assume this limits to named css colors rather than being able to use rgba/hsl/etc.
There was a problem hiding this comment.
How about Any valid CSS color value (based on this MDN page: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value)
Removing tsdx lint since it's currently broken, and adding a clean script to clear files that prettier shouldn't be concerned with.
third774
force-pushed
the
primary-color
branch
from
bc9292f to
b4e2c20
Compare
Merged
This was referenced Sep 7, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing tsdx lint since it's currently broken, and adding a clean
script to clear files that prettier shouldn't be concerned with.