Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-5639/GIN-156: add custom certificate setting to teams account re… #3253

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

alyssamw
Copy link
Contributor

Add new teams account field: custom_certificate

Waiting on release of cloudflare/cloudflare-go#1811 (merged but not yet released)

Copy link
Contributor

changelog detected ✅

@alyssamw alyssamw force-pushed the master branch 2 times, most recently from 0129b5b to dba4108 Compare April 24, 2024 19:52
@jacobbednarz
Copy link
Member

looks like we're failing in the acceptance test suite here

=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
    resource_cloudflare_teams_accounts_test.go:23: Step 1/1 error: Error running apply: exit status 1
        
        Error: error updating Teams Account configuration for account "f037e56e89293a057740de681ac9abbe": incomplete custom certificate settings
        
          with cloudflare_teams_account.dwadlgfept,
          on terraform_plugin_test.tf line 12, in resource "cloudflare_teams_account" "dwadlgfept":
          12: resource "cloudflare_teams_account" "dwadlgfept" {
        
--- FAIL: TestAccCloudflareTeamsAccounts_ConfigurationBasic (5.32s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	6.365s
FAIL
make: *** [testacc] Error 1 

@jacobbednarz
Copy link
Member

after fixing the id schema to be Computed and Optional, tests are now passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsAccounts_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccounts_ConfigurationBasic (11.64s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	12.608s

@jacobbednarz jacobbednarz merged commit 6a8b9b4 into cloudflare:master Apr 29, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.31.0 milestone Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

This functionality has been released in v4.31.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants