Add isExternal() to node:util/types (#2264)

cloudflare · Jun 13, 2024 · 799dfbe · 799dfbe
1 parent 02142cd
commit 799dfbe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/node/internal/internal_types.ts b/src/node/internal/internal_types.ts
@@ -42,6 +42,7 @@ export const isArrayBuffer = internal.isArrayBuffer.bind(internal);
 export const isArgumentsObject = internal.isArgumentsObject.bind(internal);
 export const isBoxedPrimitive = internal.isBoxedPrimitive.bind(internal);
 export const isDataView = internal.isDataView.bind(internal);
+export const isExternal = internal.isExternal.bind(internal);
 export const isMap = internal.isMap.bind(internal);
 export const isMapIterator = internal.isMapIterator.bind(internal);
 export const isModuleNamespaceObject = internal.isModuleNamespaceObject.bind(internal);
@@ -117,5 +118,5 @@ export default {
   isUint8ClampedArray,
   isUint16Array,
   isUint32Array,
-  // TODO(soon): isExternal
+  isExternal,
 };
diff --git a/src/node/internal/util.d.ts b/src/node/internal/util.d.ts
@@ -78,6 +78,7 @@ export function isBigUint64Array(value: unknown): value is BigUint64Array;
 export function isBooleanObject(value: unknown): value is Boolean;
 export function isDataView(value: unknown): value is DataView;
 export function isDate(value: unknown): value is Date;
+export function isExternal(value: unknown): boolean;
 export function isFloat32Array(value: unknown): value is Float32Array;
 export function isFloat64Array(value: unknown): value is Float64Array;
 export function isGeneratorFunction(value: unknown): value is GeneratorFunction;

diff --git a/src/workerd/api/node/util.h b/src/workerd/api/node/util.h
@@ -121,6 +121,7 @@ class MIMEType final: public jsg::Object {
   V(BooleanObject) \
   V(DataView) \
   V(Date) \
+  V(External) \
   V(Float32Array) \
   V(Float64Array) \
   V(GeneratorFunction) \