Add TraceEventInfo for TraceItem #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This work is to ultimately support a wrangler tail session on a tail worker - without a differentiating Additionally, the question remains as to whether the |
jasnell
approved these changes
Sep 27, 2023
matthewdavidrodgers
force-pushed
the
matthewrodgers/trace-events-for-trace-infos
branch
from
15c1e56
to
4f802d1
Compare
matthewdavidrodgers
added a commit
to matthewdavidrodgers/workers-sdk
that referenced
this pull request
Sep 29, 2023
When tailing a tail worker, messages previously had a null event property. Following cloudflare/workerd#1248, these events have a valid event, specifying which scripts produced events that caused your tail worker to run. As part of rolling this out, we're filtering out tail events in the internal tail infrastructure, so we control when these new messages are forward to tail sessions, and can merge this freely. One idiosyncracy to note, however, is that tail workers always report an "OK" status, even if they run out of memory or throw. That is being tracked and worked on separately.
2 tasks
matthewdavidrodgers
added a commit
to matthewdavidrodgers/workers-sdk
that referenced
this pull request
Sep 29, 2023
When tailing a tail worker, messages previously had a null event property. Following cloudflare/workerd#1248, these events have a valid event, specifying which scripts produced events that caused your tail worker to run. As part of rolling this out, we're filtering out tail events in the internal tail infrastructure, so we control when these new messages are forward to tail sessions, and can merge this freely. One idiosyncracy to note, however, is that tail workers always report an "OK" status, even if they run out of memory or throw. That is being tracked and worked on separately.
matthewdavidrodgers
added a commit
to matthewdavidrodgers/workers-sdk
that referenced
this pull request
Sep 29, 2023
When tailing a tail worker, messages previously had a null event property. Following cloudflare/workerd#1248, these events have a valid event, specifying which scripts produced events that caused your tail worker to run. As part of rolling this out, we're filtering out tail events in the internal tail infrastructure, so we control when these new messages are forward to tail sessions, and can merge this freely. One idiosyncracy to note, however, is that tail workers always report an "OK" status, even if they run out of memory or throw. That is being tracked and worked on separately.
matthewdavidrodgers
force-pushed
the
matthewrodgers/trace-events-for-trace-infos
branch
from
4f802d1
to
a76cbb1
Compare
|
this probably needs to hold a sec, we probably want to change "traces" per product decisions |
matthewdavidrodgers
force-pushed
the
matthewrodgers/trace-events-for-trace-infos
branch
from
d4ebb9c
to
921020a
Compare
Updated to change This is now ready to go |
matthewdavidrodgers
added a commit
to matthewdavidrodgers/workers-sdk
that referenced
this pull request
Oct 3, 2023
When tailing a tail worker, messages previously had a null event property. Following cloudflare/workerd#1248, these events have a valid event, specifying which scripts produced events that caused your tail worker to run. As part of rolling this out, we're filtering out tail events in the internal tail infrastructure, so we control when these new messages are forward to tail sessions, and can merge this freely. One idiosyncracy to note, however, is that tail workers always report an "OK" status, even if they run out of memory or throw. That is being tracked and worked on separately.
This adds a new TraceItem::EventType union member - TraceEventInfo. This allows event info for invocations of a trace or tail worker to show up when tailing it (i.e. attaching a tail to a tail worker). TraceEventInfo only contains an array "traces" of objects with a single "scriptName", i.e. the script that the script _you're_ tracing was tracing. There's hypothetically more that could be included on these items, but any sort of recursive could ballon the size of these events or even get into circular references, so it's kept simple for now.
matthewdavidrodgers
force-pushed
the
matthewrodgers/trace-events-for-trace-infos
branch
from
921020a
to
d3cc155
Compare
ObsidianMinor
approved these changes
Oct 5, 2023
matthewdavidrodgers
deleted the
matthewrodgers/trace-events-for-trace-infos
branch
matthewdavidrodgers
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 6, 2023
When tailing a tail worker, messages previously had a null event property. Following cloudflare/workerd#1248, these events have a valid event, specifying which scripts produced events that caused your tail worker to run. As part of rolling this out, we're filtering out tail events in the internal tail infrastructure, so we control when these new messages are forward to tail sessions, and can merge this freely. One idiosyncracy to note, however, is that tail workers always report an "OK" status, even if they run out of memory or throw. That is being tracked and worked on separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new TraceItem::EventType union member - TraceEventInfo. This allows event info for invocations of a trace or tail worker to show up when tailing it (i.e. attaching a tail to a tail worker).
TraceEventInfo only contains an array "traces" of objects with a single "scriptName", i.e. the script that the script you're tracing was tracing. There's hypothetically more that could be included on these items, but any sort of recursive could ballon the size of these events or even get into circular references, so it's kept simple for now.