Await connection and flush before closing socket. #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Jan 13, 2024
jasnell
reviewed
Jan 13, 2024
jasnell
reviewed
Jan 13, 2024
dom96
force-pushed
the
dominik/flush-on-socket-close-2
branch
from
634a33a
to
f19b959
Compare
|
@jasnell should be ready to go |
jasnell
approved these changes
Jan 18, 2024
dom96
force-pushed
the
dominik/flush-on-socket-close-2
branch
3 times, most recently
from
be83106
to
9e00f8b
Compare
dom96
commented
Jan 24, 2024
src/workerd/api/streams/internal.h
Outdated
| @@ -143,6 +147,10 @@ class ReadableStreamInternalController: public ReadableStreamController { | |||
| bool disturbed = false; | |||
| bool readPending = false; | |||
|
|
|||
| // Used by Sockets code to signal to the ReadableStream that it should error when read from | |||
| // because the socket is currently being closed. | |||
| bool errorOnReadsDueToPendingClosure = false; | |||
There was a problem hiding this comment.
Other idea is to stick it into the StreamState but there seems to be a bunch of code that checks for !StreamState.is<Unlocked> and I didn't want to mess with it.
jasnell
reviewed
Jan 24, 2024
jasnell
approved these changes
Jan 24, 2024
dom96
force-pushed
the
dominik/flush-on-socket-close-2
branch
from
9e00f8b
to
fd8d741
Compare
dom96
force-pushed
the
dominik/flush-on-socket-close-2
branch
from
fd8d741
to
9b89c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeat of https://github.com/cloudflare/workerd/pull/1369/files with some changes.
Behind an autogate so we can roll this out gradually.
Tested upstream.