Refactor jsg::V8StackScope into callback-based API #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/refactor-v8stackscope
branch
2 times, most recently
from
e6478e1
to
a26e9a0
Compare
Defining `jsg::V8StackScope` as a stack is problematic as it does
not guarantee that the stack start will be set correctly in v8.
This commit refactors the API to use a callback pattern instead.
```
jsg::runInV8Stack([&](jsg::V8StackScope& stackScope) {
// ...
});
```
harrishancock
approved these changes
Jan 22, 2024
jasnell
force-pushed
the
jsnell/refactor-v8stackscope
branch
2 times, most recently
from
4331c36
to
183ec8f
Compare
kentonv
reviewed
Jan 22, 2024
jasnell
force-pushed
the
jsnell/refactor-v8stackscope
branch
from
183ec8f
to
7a5188f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining
jsg::V8StackScopeas a stack is problematic as it does not guarantee that the stack start will be set correctly in v8. This commit refactors the API to use a callback pattern instead.See the primary change in
jsg.h.. the rest is updating the usage sites.As a follow-on PR, I also plan to change the Lock-taking API into a callback-style also.