Update pyodide to 0.25.0 #1576
Update pyodide to 0.25.0 #1576
Conversation
hoodmane
requested review from
byule and
vickykont
and removed request for
a team
| @@ -18,6 +18,7 @@ struct Module { | |||
| src @1 :Data; # JS / TS code | |||
| wasm @4 :Data; # Wasm module | |||
| data @5 :Data; # Binary data module | |||
| json @6 :Text; # Json module | |||
There was a problem hiding this comment.
This is nice, but I wonder if there is a reason we haven't introduced this in the past. We'll have to add this in edgeworker too I suppose and I want to make sure the team is happy with this direction (just calling it out here so hopefully if someone has objections they can call them out)
There was a problem hiding this comment.
Well I didn't introduce this in the wasm/data PRs because I wasn't including pyodide-package.json at all then. It seems much preferable to include them as json than to try to do some brittle rewrite on the source.
| scheme = url.protocol[:-1] | ||
| path = url.pathname | ||
| assert url.search[0] == '?' | ||
| assert "?".startswith(url.search[0:1]) |
There was a problem hiding this comment.
curious about this, the former is far clearer, why the change?
There was a problem hiding this comment.
url.search can also be empty, the previous assert would throw an error in this case. Probably saying
not url.search or url.search[0] == "?"is clearer
hoodmane
force-pushed
the
hoodmane/update-pyodide
branch
from
763c7dd
to
b2fe5c3
Compare
And tidy up loading process: 1. switch Python metadata from a user js module to an internal json module 2. switch lockfile.js to a json file and add capability for builtin json modules
hoodmane
force-pushed
the
hoodmane/update-pyodide
branch
from
b2fe5c3
to
4fe9bc1
Compare
And tidy up loading process: