sqlite: don't count rows written to temporary (ephemeral) tables #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixup: 3044e11 |
SQLite may generate temporary tables while executing a SELECT statement. Rows written to these tables shouldn't count as they're not under control of the user. This change is essentially tursodatabase/libsql@5d6c79e, which does this same thing in libsql; libsql is also where the original row-counting logic comes from. The test was written by glen@cloudflare.com.
smerritt
force-pushed
the
smerritt/sqlite-dont-count-ephemeral-writes
branch
from
3044e11 to
4226541
Compare
|
An existing test was broken; it was updating 2 of 4 rows in an indexed table and asserting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite may generate temporary tables while executing a SELECT statement. Rows written to these tables shouldn't count as they're not under control of the user.
This change is essentially
tursodatabase/libsql@5d6c79e, which does this same thing in libsql; libsql is also where the original row-counting logic comes from.
The test was written by glen@cloudflare.com.