Fixup gc visitation in streams readers and writers #1598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/fix-gcvisiting-streams-writers-readers
branch
from
3a909a4 to
20d3ef5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kentonv
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Does the change to WeakRef fix a problem or is it just aesthetics? I personally find it more confusing, and I worry that the complexity of the commit could hide new bugs. If it doesn't fix a bug I'd prefer to drop that commit on the basis of "if it ain't broke, don't fix it"...
jasnell
force-pushed
the
jsnell/fix-gcvisiting-streams-writers-readers
branch
from
2bf2bef to
918f104
Compare
Fixes a problem in the cleanup ordering that was masked by the memory leak. |
jasnell
force-pushed
the
jsnell/fix-gcvisiting-streams-writers-readers
branch
from
918f104 to
5e78eaa
Compare
|
Superseded by #1606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR does a couple of things: