Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #pragma once from memory.c++ #1629

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

justin-mp
Copy link
Contributor

This fixes a warning from clang:

INFO: From Compiling src/workerd/jsg/memory.c++:
src/workerd/jsg/memory.c++:1:9: warning: #pragma once in main file [-Wpragma-once-outside-header]
#pragma once
^
1 warning generated.

This fixes a warning from clang:

> INFO: From Compiling src/workerd/jsg/memory.c++:
> src/workerd/jsg/memory.c++:1:9: warning: #pragma once in main file [-Wpragma-once-outside-header]
> #pragma once
>         ^
> 1 warning generated.
@justin-mp justin-mp requested review from a team as code owners February 7, 2024 12:19
@justin-mp justin-mp requested review from byule, dom96 and jasnell February 7, 2024 12:19
@jasnell
Copy link
Member

jasnell commented Feb 7, 2024

ha! sigh, gotta love that muscle memory. thank you :-)

@justin-mp justin-mp merged commit acddd81 into main Feb 7, 2024
11 checks passed
@justin-mp justin-mp deleted the justin-mp/tidy-memory-pragma-once branch February 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants