Implement heap snapshot memorytracker for http types #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
approved these changes
Feb 7, 2024
Comment on lines
+1162
to
+1164
| KJ_IF_SOME(respondWithCalled, state.tryGet<RespondWithCalled>()) { | ||
| visitor.visit(respondWithCalled.promise); | ||
| } |
There was a problem hiding this comment.
Does this fix a memory leak?
There was a problem hiding this comment.
It might. If the promise is left dangling and any closures attached to it happen to create a cycle then yes, it could have leaked. A big part of the reason I'm adding this memorytracker mechanism is to help find anything potentially like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.