Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buffer.transcode to nodejs_compat #2462

Merged
merged 2 commits into from
Aug 5, 2024
Merged

add buffer.transcode to nodejs_compat #2462

merged 2 commits into from
Aug 5, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 30, 2024

This pull-request adds require('node:buffer').transcode() support. It uses ICU for most encodings, and simdutf for latin1, utf8 and utf-16 operations.

@anonrig anonrig requested a review from jasnell July 30, 2024 14:57
@anonrig anonrig requested review from a team as code owners July 30, 2024 14:57
@anonrig anonrig requested a review from garrettgu10 July 30, 2024 14:57
@anonrig anonrig force-pushed the yagiz/buffer-transcode branch from eb1d55e to 935fe01 Compare July 30, 2024 15:02
@anonrig anonrig marked this pull request as draft July 30, 2024 15:03
@anonrig anonrig force-pushed the yagiz/buffer-transcode branch from 935fe01 to f6063e3 Compare July 30, 2024 15:11
@anonrig anonrig force-pushed the yagiz/buffer-transcode branch 6 times, most recently from 1299807 to f171dbd Compare July 30, 2024 17:11
@anonrig anonrig force-pushed the yagiz/buffer-transcode branch 2 times, most recently from f4a7d0c to 928e981 Compare August 1, 2024 17:07
@anonrig anonrig requested a review from jasnell August 1, 2024 17:07
jasnell
jasnell previously approved these changes Aug 1, 2024
@jasnell jasnell dismissed their stale review August 1, 2024 18:42

few nits to address

@anonrig anonrig force-pushed the yagiz/buffer-transcode branch from 928e981 to d282e23 Compare August 1, 2024 19:39
@anonrig anonrig requested review from danlapid and jasnell August 1, 2024 19:42
@jasnell
Copy link
Member

jasnell commented Aug 1, 2024

Adding the "needs-internal-pr" label on this to ensure that we make certain that the internal CI run is green before this lands. Once the internal CI comes back green with this change, the label can be removed and the PR can be merged

@anonrig anonrig force-pushed the yagiz/buffer-transcode branch from 4217fe5 to 9e26f4e Compare August 2, 2024 17:11
@anonrig anonrig force-pushed the yagiz/buffer-transcode branch from 9e26f4e to 95838ff Compare August 2, 2024 19:16
@anonrig
Copy link
Member Author

anonrig commented Aug 5, 2024

Internal PR is now resolved. We can merge this now.

@anonrig anonrig merged commit 17b52c5 into main Aug 5, 2024
9 of 10 checks passed
@anonrig anonrig deleted the yagiz/buffer-transcode branch August 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants