Switch back to id for Workflows binding #2975
Merged
+23
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
approved these changes
Oct 22, 2024
a-robinson
approved these changes
Oct 22, 2024
| @@ -35,9 +28,9 @@ declare abstract class Workflow { | |||
|
|
|||
| interface WorkflowInstanceCreateOptions { | |||
| /** | |||
| * A name for your Workflow instance. Must be unique within the Workflow. | |||
| * An id for your Workflow instance. Must be unique within the Workflow. | |||
There was a problem hiding this comment.
It'd be nice to mention that if an ID isn't specified, a unique ID will be generated for you. It looks like you already did that in the file above (src/cloudflare/internal/workflows.d.ts), just missed it here.
But this is fine to merge either way 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.