Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrappers for gdb and lldb when invoked from bazel #508

Closed
wants to merge 1 commit into from
Closed

Add wrappers for gdb and lldb when invoked from bazel #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tools/bazel-gdb-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/bin/bash
#
# A wrapper script so workerd can be debugged with gdb, if invoked via bazel run.
#
# Example command-line invocation:
#
# bazel run -c dbg --run_under $(realpath tools/bazel-gdb-wrapper.sh) \
# //src/workerd/server:workerd -- serve samples/helloworld_esm/config.capnp
#

set -euo pipefail

cd "${BUILD_WORKSPACE_DIRECTORY}"
gdb --args "$@"
17 changes: 17 additions & 0 deletions tools/bazel-lldb-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/bash
#
# A wrapper script so workerd can be debugged with lldb, if invoked via bazel run.
#
# Example command-line invocation:
#
# bazel run -c dbg --spawn_strategy=local --features=oso_prefix_is_pwd --run_under \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment suggests to me that the features flag alone is sufficient and we should be able to at least do away with the local spawn_strategy?

Copy link
Contributor Author

@ohodson ohodson Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I cannot tell you how much time I wasted with this OSX only issue, it does indeed appear redundant.

# $(realpath tools/bazel-lldb-wrapper.sh) \
# //src/workerd/server:workerd -- serve samples/helloworld_esm/config.capnp
#
# NB the additional spawn_strategy and features flags are necessary on OS X per
# https://github.com/bazelbuild/bazel/issues/6327.

set -euo pipefail

cd "${BUILD_WORKSPACE_DIRECTORY}"
lldb -- "$@"