-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Fetcher#scheduled()
for dispatching scheduled
events
#961
Conversation
f294b08
to
7c9a9b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's also get @kentonv's opinion
Like `Fetcher#queue()`, this is gated behind the experimental `service_binding_extra_handlers` compatibility flag. Co-authored-by: jjohnson <jjohnson@cloudflare.com>
7c9a9b0
to
a63a409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me as long as it stays guarded by that compat flag. We'd need to do some thinking before making this more generally available.
Hey! 👋 This PR implements a
Fetcher#scheduled()
method for dispatchingscheduled
events to bound services. This will allow us to add support for triggering scheduled events in Miniflare without transforming user code. LikeFetcher#queue()
, this is gated behind the experimentalservice_binding_extra_handlers
compatibility flag.