Fixed cyclic reference in cargo. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en::JsValue::into_serde that have been deprecated. Added the new serde_wasm_bindgen::from_value() and serde_wasm_bindgen::to_value() equivalents instead.
Merge CF upstream
|
It would be great to see this change merged. 🙂 |
|
@zebp 🤓 |
zebp
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes worker to use serde-wasm-bindgen package, rather than relying on the deprecated serde option in wasm-bindgen.
Description of the cyclic reference issue that I was hitting is here:
tkaitchuck/aHash#95
wasm_bindgen::JsValue::from_serde and wasm_bindgen::JsValue::into_serde are deprecated here (citing the cyclic reference issue that I encountered).
rustwasm/wasm-bindgen#3031
Also, additional description of serde-wasm-bindgen is found here (turns out that it was written by Cloudflare).
rustwasm/wasm-bindgen#1258
This patch replaces the usage of wasm_bindgen::JsValue::from_serde and wasm_bindgen::JsValue::into_serde with serde_wasm_bindgen::from_value() and serde_wasm_bindgen::to_value() equivalents.
Together with this patch in workers-kv here, the observed cyclic reference issues are gone.