🐛 BUG: .raw() does not work locally

[AlexBlokh]

What version of Wrangler are you using?

2.4.2

What operating system are you using?

Mac

Describe the Bug

const rows = await env.DB.prepare('select id, email from users').raw();
console.log(rows);

prints locally:

Statement {
  busy: false,
  reader: true,
  readonly: true,
  source: 'select id, email from users',
  database: Database {
    name: '/Users/alexblokh/Development/drizzle-orm-new/cloudflare/.wrangler/state/d1/DB.sqlite3',
    open: true,
    inTransaction: false,
    readonly: false,
    memory: false
  }
}

prints in cloud:

[
  [
    "e@ma.il",
    6
  ],
  [
    "e@ma.il",
    7
  ]
]

[maurerbot]

Plus 1 on this if possible

[rozenmd]

FYI @mrbbot, looks like miniflare's behaviour doesn't match the d1 facade:

// packages/wrangler/templates/d1-beta-facade.js
async raw() {
		const s = firstIfArray(
			await this.database._send("/query", this.statement, this.params)
		);
		const raw = [];
		for (var r in s.results) {
			const entry = Object.keys(s.results[r]).map((k) => {
				return s.results[r][k];
			});
			raw.push(entry);
		}
		return raw;
	}

vs https://github.com/cloudflare/miniflare/blob/master/packages/d1/src/statement.ts#L127-L130

I'll make a PR updating miniflare to make its behaviour match the shim

[maurerbot]

thanks @rozenmd

[maurerbot]

any ETA on this?

[rozenmd]

@maurerbot we don't give ETAs, but PRs are also welcome if you'd like the fix ASAP.

[maurerbot]

I might do it. But only for the cred! 😄

[maurerbot]

@rozenmd @mrbbot not sure if this is right? cloudflare/miniflare#471

Tests pass but could use guidance on how the abstraction works?

[repository]

Hi, please forgive me if I am missing something obvious, but I think we are overcomplicating this.

I looked at the docs for better-sqlite3 to figure out what the .raw() method does. As it turns out, it only enables the raw mode for that statement (and returns the statement), not actually executing it. In miniflare, it is only calling that .raw() from bsqlite3 and nothing further, so that's why we're getting a statement back as illustrated by AlexBlokh.

I simply called .all() after raw in miniflare and it seems to work now for me, but there might some case that I'm not aware of.

This PR implements that change and hopefully resolves this issue.
cloudflare/miniflare#474

[AlexBlokh]

@repository hey
.raw() does return a result of T[] due to your types and does it as stated when deployed to the worker

Latest worker types shows the same