Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Wrangler requests login on dry run due to standardPricingWarning #4723

Closed
roshanr95 opened this issue Jan 8, 2024 · 1 comment · Fixed by #4880 or #4854
Closed

🐛 BUG: Wrangler requests login on dry run due to standardPricingWarning #4723

roshanr95 opened this issue Jan 8, 2024 · 1 comment · Fixed by #4880 or #4854
Labels
bug Something that isn't working

Comments

@roshanr95
Copy link

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

3.22.3 [Wrangler]

What version of Node are you using?

v18.16.0

What operating system are you using?

Linux

Describe the Bug

Wrangler asks for a login even when dry-run is specified. I traced the call to the standardPricingWarning function call here - https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/src/deploy/index.ts#L293

Commenting out the call fixes it (as a hack), ignoring it on dry runs would be helpful.

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

Output from console.trace() inside the login method:

Trace
    at login (/node_modules/wrangler/wrangler-dist/cli.js:119073:11)
    at loginOrRefreshIfRequired (/node_modules/wrangler/wrangler-dist/cli.js:119058:49)
    at requireLoggedIn (/node_modules/wrangler/wrangler-dist/cli.js:119406:26)
    at performApiFetch (/node_modules/wrangler/wrangler-dist/cli.js:119331:9)
    at fetchInternal (/node_modules/wrangler/wrangler-dist/cli.js:119355:26)
    at fetchResult (/node_modules/wrangler/wrangler-dist/cli.js:119507:22)
    at standardPricingWarning (/node_modules/wrangler/wrangler-dist/cli.js:136869:40)
    at Object.deployHandler [as handler] (/node_modules/wrangler/wrangler-dist/cli.js:137073:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
@roshanr95 roshanr95 added the bug Something that isn't working label Jan 8, 2024
@roshanr95 roshanr95 changed the title 🐛 BUG: Wrangler requests login requested on dry run due to standardPricingWarning 🐛 BUG: Wrangler requests login on dry run due to standardPricingWarning Jan 8, 2024
@petero-dk
Copy link
Contributor

This is crazy annoying since we use the dryRun to do builds in a non authenticated environment, and such an easy fix! I just added a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
2 participants