-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude standardPricingWarning from dryrun #4845
Conversation
That way we do not need authentication for dryrun, again.
|
I think there is actually value in having a changeset here, since it does change a user facing experience. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-wrangler-4845 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4845/npm-package-wrangler-4845 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-wrangler-4845 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-create-cloudflare-4845 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-miniflare-4845 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-cloudflare-pages-shared-4845 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4845 +/- ##
==========================================
+ Coverage 70.70% 70.76% +0.06%
==========================================
Files 291 291
Lines 15164 15165 +1
Branches 3859 3860 +1
==========================================
+ Hits 10721 10731 +10
+ Misses 4443 4434 -9
|
Hi @petero-dk - I have moved this PR over to #4880 since you did not allow contributors to push to your branch and I wanted to fix up the formatting and add the changeset. You should still get the recognition for the fix. |
@petebacondarwin excellent. I'm just happy for the fix 😊 thank you for fixing the issues |
That way we do not need authentication for dryrun, again.
Fixes #4723
What this PR solves / how to test:
Install wrangler, don't login (or logout) run a dryRun deploy, see that you are asked to login. Install PR, see that you are no longer required to login when doing a dryRun deploy.
Author has addressed the following: