Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude standardPricingWarning from dryrun #4845

Closed
wants to merge 1 commit into from

Conversation

petero-dk
Copy link
Contributor

That way we do not need authentication for dryrun, again.

Fixes #4723

What this PR solves / how to test:

Install wrangler, don't login (or logout) run a dryRun deploy, see that you are asked to login. Install PR, see that you are no longer required to login when doing a dryRun deploy.

Author has addressed the following:

  • Tests
    • Not necessary because: fixes a non-tested bug
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: trivial fix
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: trivial bug

That way we do not need authentication for dryrun, again.
@petero-dk petero-dk requested a review from a team as a code owner January 26, 2024 13:27
Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 1a4a8d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin
Copy link
Contributor

I think there is actually value in having a changeset here, since it does change a user facing experience.

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-wrangler-4845

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4845/npm-package-wrangler-4845

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-wrangler-4845 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-create-cloudflare-4845 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-miniflare-4845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7668686458/npm-package-cloudflare-pages-shared-4845

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.24.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.3
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3c5566) 70.70% compared to head (1a4a8d3) 70.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4845      +/-   ##
==========================================
+ Coverage   70.70%   70.76%   +0.06%     
==========================================
  Files         291      291              
  Lines       15164    15165       +1     
  Branches     3859     3860       +1     
==========================================
+ Hits        10721    10731      +10     
+ Misses       4443     4434       -9     
Files Coverage Δ
packages/wrangler/src/deploy/index.ts 96.61% <100.00%> (+0.05%) ⬆️

... and 8 files with indirect coverage changes

@petebacondarwin
Copy link
Contributor

Hi @petero-dk - I have moved this PR over to #4880 since you did not allow contributors to push to your branch and I wanted to fix up the formatting and add the changeset. You should still get the recognition for the fix.

@petero-dk
Copy link
Contributor Author

@petebacondarwin excellent. I'm just happy for the fix 😊 thank you for fixing the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Wrangler requests login on dry run due to standardPricingWarning
2 participants