-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: Support for interactivity in e2e tests #3613
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5612799115/npm-package-wrangler-3613 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3613/npm-package-wrangler-3613 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5612799115/npm-package-wrangler-3613 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5612799115/npm-package-cloudflare-pages-shared-3613 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3613 +/- ##
==========================================
+ Coverage 75.19% 75.24% +0.04%
==========================================
Files 190 190
Lines 11161 11161
Branches 2944 2944
==========================================
+ Hits 8393 8398 +5
+ Misses 2768 2763 -5 |
d2e67a1
to
12bf0a0
Compare
2cbbce7
to
3fbaa4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, I just left some minor comments/suggestions 😄
* C3: Add e2e tests that exercise interactive flows * C3: Adding e2e tests for previously skipped frameworks * Fixing unit tests * C3: fixing e2e test run * C3: Refactoring tmp folder creation in c3 e2e tests
Adds e2e coverage that exercises interactive flows by matching output from stdout and emulating users keystrokes. This is useful to catch issues that arise when input can be supplied via command line arguments or interactive prompts.
This also opens the way to test some of the frameworks we couldn't before since completing the process requires some amount of user input.
What this PR solves / how to test:
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: