Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --local to r2 object commands #3703

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add --local to r2 object commands #3703

merged 1 commit into from
Aug 3, 2023

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Aug 2, 2023

Add --local and --persist-to options to r2 object commands to interact with local persisted storage

Associated docs issue(s)/PR(s):

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jspspike jspspike requested review from a team as code owners August 2, 2023 18:07
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 69081c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jspspike jspspike requested a review from mrbbot August 2, 2023 18:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-wrangler-3703

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5753918712/npm-package-wrangler-3703

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-wrangler-3703 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-cloudflare-pages-shared-3703

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙂 A couple comments, and looks like there's some linting errors to fix too. 👍

packages/wrangler/src/__tests__/r2.test.ts Show resolved Hide resolved
packages/wrangler/src/r2/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/r2/helpers.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/r2-local branch 2 times, most recently from 4a14262 to 1447dcf Compare August 3, 2023 15:56
@jspspike jspspike requested a review from mrbbot August 3, 2023 15:56
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3703 (69081c6) into main (ff8603b) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   75.17%   75.24%   +0.06%     
==========================================
  Files         195      195              
  Lines       11407    11438      +31     
  Branches     3013     3023      +10     
==========================================
+ Hits         8575     8606      +31     
  Misses       2832     2832              
Files Changed Coverage Δ
packages/wrangler/src/r2/index.ts 87.30% <76.66%> (-2.13%) ⬇️
packages/wrangler/src/r2/helpers.ts 97.67% <100.00%> (+0.61%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One tiny comment, then let's merge. 👍

packages/wrangler/src/__tests__/r2.test.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/r2-local branch from 1447dcf to 69081c6 Compare August 3, 2023 17:35
@jspspike jspspike merged commit e600f02 into main Aug 3, 2023
@jspspike jspspike deleted the jspspike/r2-local branch August 3, 2023 17:44
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants