-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --local to r2 object commands #3703
Conversation
🦋 Changeset detectedLatest commit: 69081c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-wrangler-3703 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5753918712/npm-package-wrangler-3703 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-wrangler-3703 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5753918712/npm-package-cloudflare-pages-shared-3703 Note that these links will no longer work once the GitHub Actions artifact expires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙂 A couple comments, and looks like there's some linting errors to fix too. 👍
4a14262
to
1447dcf
Compare
Codecov Report
@@ Coverage Diff @@
## main #3703 +/- ##
==========================================
+ Coverage 75.17% 75.24% +0.06%
==========================================
Files 195 195
Lines 11407 11438 +31
Branches 3013 3023 +10
==========================================
+ Hits 8575 8606 +31
Misses 2832 2832
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One tiny comment, then let's merge. 👍
1447dcf
to
69081c6
Compare
Add
--local
and--persist-to
options to r2 object commands to interact with local persisted storageAssociated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.