-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix usage of shell-quote.parse on windows #4105
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #4105 +/- ##
==========================================
+ Coverage 75.09% 75.12% +0.02%
==========================================
Files 217 217
Lines 12075 12077 +2
Branches 3127 3128 +1
==========================================
+ Hits 9068 9073 +5
+ Misses 3007 3004 -3
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6411961053/npm-package-wrangler-4105 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6411961053/npm-package-wrangler-4105 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6411961053/npm-package-wrangler-4105 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6411961053/npm-package-cloudflare-pages-shared-4105 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
On Windows, paths contain
\
characters as delimiters. Our command parser was interpreting these as backslash escape characters. This is essentially a double encoding bug.This fixes the issue on Windows by replacing the backslash characters with a double-backslash which will be interpreted as an escaped backslash (i.e. a single backslash).
The double and quadruple backslashes in the
cmd.replace(...)
call are a double-encoding of themselves but I'm sure everyone reviewing this is aware.Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.