-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: E2E logging refactor #4164
C3: E2E logging refactor #4164
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563772933/npm-package-wrangler-4164 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6563772933/npm-package-wrangler-4164 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563772933/npm-package-wrangler-4164 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563772933/npm-package-cloudflare-pages-shared-4164 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
04f0e62
to
ebb1487
Compare
Codecov Report
@@ Coverage Diff @@
## main #4164 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 223 223
Lines 12217 12217
Branches 3159 3159
=======================================
Hits 9209 9209
Misses 3008 3008 |
f2a347a
to
c4777e1
Compare
What this PR solves / how to test:
This is a long overdue rework of how we handle logging in c3 e2e tests.
The current e2e logging situation is extremely annoying. The test runner pipes output directly to stdout with minimal filtering, and since the output contains interactive cli commands it's usually cluttered with various animations and terminal escape codes. To make matters worse, tests are run in parallel and output to the same stdout, which means that the output of multiple frameworks are interleaved with one another, making almost impossible to discern where the output of the problematic test begins and ends.
This PR changes things by:
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.