Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: don't retry the project creation multiple times when it fails because the project's name is already used #4220

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

dario-piotrowicz
Copy link
Member

When trying to create a new pages project with C3 that is reusing the same name as an already existing project (for the same account) we retry the project creation multiple times, these add an exit condition to out retry logic so that we don't retry multiple times in such cases.

Before

Screenshot 2023-10-18 at 16 53 58

After

Screenshot 2023-10-18 at 16 54 16

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner October 18, 2023 15:56
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 081b5be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563737648/npm-package-wrangler-4220

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6563737648/npm-package-wrangler-4220

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563737648/npm-package-wrangler-4220 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6563737648/npm-package-cloudflare-pages-shared-4220

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.13.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231016.0 3.20231016.0
workerd 1.20231016.0 1.20231016.0
workerd --version 1.20231016.0 2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz merged commit 2b4d9de into main Oct 18, 2023
24 checks passed
@dario-piotrowicz dario-piotrowicz deleted the duplicate-projects-name-no-retry branch October 18, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants