Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miniflare] Bump Miniflare Durable Object eviction test timeout #4320

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 1, 2023

What this PR solves / how to test:

I've seen this test time out a couple of times in CI. Increasing the timeout to hopefully prevent this happening again. Note, this shouldn't make the tests run any slower, it just means if they do, they won't fail. 👍

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: bumping timeout in existing test
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: not a user facing change
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: not a user facing change

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner November 1, 2023 16:41
Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: f1ed716

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot changed the title ]Bump Miniflare Durable Object eviction test timeout [miniflare] Bump Miniflare Durable Object eviction test timeout Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6722487472/npm-package-wrangler-4320

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6722487472/npm-package-wrangler-4320

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6722487472/npm-package-wrangler-4320 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6722487472/npm-package-miniflare-4320
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6722487472/npm-package-cloudflare-pages-shared-4320

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas
Copy link
Contributor

RamIdeas commented Nov 1, 2023

Should've thought about this, sorry!

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4320 (f1ed716) into main (a4a89ae) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4320      +/-   ##
==========================================
+ Coverage   75.34%   75.39%   +0.04%     
==========================================
  Files         223      223              
  Lines       12341    12341              
  Branches     3190     3190              
==========================================
+ Hits         9298     9304       +6     
+ Misses       3043     3037       -6     

see 4 files with indirect coverage changes

@mrbbot mrbbot merged commit d80e945 into main Nov 1, 2023
19 of 20 checks passed
@mrbbot mrbbot deleted the bcoll/bump-do-eviction-timeout branch November 1, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants