Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump workerd #4324

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Bump workerd #4324

merged 3 commits into from
Nov 6, 2023

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Nov 1, 2023

Bump miniflare to latest workerd version.

@penalosa penalosa requested a review from a team as a code owner November 1, 2023 22:10
Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: 62dffe6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 1, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6735114757/npm-package-wrangler-4324

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6735114757/npm-package-wrangler-4324

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6735114757/npm-package-wrangler-4324 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6735114757/npm-package-miniflare-4324
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6735114757/npm-package-cloudflare-pages-shared-4324

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4324 (62dffe6) into main (d80e945) will increase coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4324      +/-   ##
==========================================
+ Coverage   75.34%   75.37%   +0.03%     
==========================================
  Files         223      223              
  Lines       12341    12342       +1     
  Branches     3190     3191       +1     
==========================================
+ Hits         9298     9303       +5     
+ Misses       3043     3039       -4     
Files Coverage Δ
packages/wrangler/src/dev/local.tsx 22.68% <0.00%> (-0.24%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a changeset? 😅

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that we can do minfilare and wrangler changes together, could you update logToTerminal here so it's enabled if the bundle is a service worker?

logToTerminal: false,

"miniflare": minor
---

Update to latest `workerd`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to include the workerd version and a link to the changelog here.

@penalosa penalosa merged commit 16cc2e9 into main Nov 6, 2023
17 of 20 checks passed
@penalosa penalosa deleted the penalosa/bump-workerd branch November 6, 2023 15:19
@workers-devprod workers-devprod mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants