Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dev registry and inspector server to use 127.0.0.1 instead of all interfaces #4437

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Nov 13, 2023

Fixes #4430

The dev registry and inspector server listen on all interfaces when running wrangler dev, this might not be desired by users who use --ip to prevent listening beyond localhost. This PR will will make the dev registry and inspector server use 127.0.0.1

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: Not a change that is user facing or affects user behavior

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jspspike jspspike requested a review from a team as a code owner November 13, 2023 22:13
Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: ba1f074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 13, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-wrangler-4437

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6868977660/npm-package-wrangler-4437

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-wrangler-4437 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-miniflare-4437
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-cloudflare-pages-shared-4437

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #4437 (ba1f074) into main (be36619) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4437      +/-   ##
==========================================
+ Coverage   75.46%   75.50%   +0.03%     
==========================================
  Files         225      225              
  Lines       12478    12478              
  Branches     3239     3239              
==========================================
+ Hits         9417     9421       +4     
+ Misses       3061     3057       -4     
Files Coverage Δ
packages/wrangler/src/dev-registry.ts 68.88% <100.00%> (ø)
packages/wrangler/src/dev/inspect.ts 5.27% <0.00%> (ø)

... and 3 files with indirect coverage changes

@jspspike jspspike force-pushed the jspspike/dev-ip branch 3 times, most recently from c972768 to 937cdca Compare November 14, 2023 16:01
@jspspike jspspike marked this pull request as draft November 14, 2023 19:32
@jspspike jspspike marked this pull request as ready for review November 14, 2023 20:18
@jspspike jspspike merged commit 05b1bbd into main Nov 16, 2023
17 checks passed
@jspspike jspspike deleted the jspspike/dev-ip branch November 16, 2023 15:39
mrbbot pushed a commit that referenced this pull request Dec 11, 2023
mrbbot added a commit that referenced this pull request Dec 12, 2023
* Change dev registry and inspector server to use 127.0.0.1 instead of all interfaces (#4437)

(cherry picked from commit 05b1bbd)

* fix: validate `Host`/`Origin` headers in inspector proxy

Backport of #4550

---------

Co-authored-by: Joshua Johnson <jspspike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Wrangler is still listening on the wildcard address even with --ip localhost
3 participants