fix: init from dash using explicit usage model for standard accounts

[zebp]

What this PR solves / how to test:

Fixes a bug where users with the standard usage model would have an explicit usage model defined in their wrangler.toml when they initialized a Worker from dash. Testing can be done by building and then running wrangler init --from-dash [worker] -y --no-delegate-c3 on an account that has opted into the new standard pricing and ensuring there is no usage model defined in the config.

Author has addressed the following:

• Tests
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s):
  • Not necessary because: this is a bug fix to match existing defined behavior

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 444a667

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7061322025/npm-package-wrangler-4521

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7061322025/npm-package-wrangler-4521

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7061322025/npm-package-wrangler-4521 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7061322025/npm-package-miniflare-4521

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7061322025/npm-package-cloudflare-pages-shared-4521

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7061322025/npm-package-create-cloudflare-4521

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.18.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231030.2
workerd	1.20231030.0	1.20231030.0
workerd --version	1.20231030.0	2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #4521 (3881974) into main (18a4dd9) will increase coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 3881974 differs from pull request most recent head 444a667. Consider uploading reports for the commit 444a667 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4521      +/-   ##
==========================================
+ Coverage   75.44%   75.45%   +0.01%     
==========================================
  Files         240      240              
  Lines       12851    12854       +3     
  Branches     3309     3312       +3     
==========================================
+ Hits         9695     9699       +4     
+ Misses       3156     3155       -1     

Files	Coverage Δ
packages/wrangler/src/init.ts	91.83% <66.66%> (-0.19%)	⬇️

... and 5 files with indirect coverage changes

[mrbbot]

Hey! 👋 Thanks for opening this PR! I see you noticed there's already an in-flight PR that fixes this behaviour in a slightly different way. Could we close this PR and discuss which solution to use on #4470 instead, or does this need to go in sooner?

[zebp]

Hey! 👋 Thanks for opening this PR! I see you noticed there's already an in-flight PR that fixes this behaviour in a slightly different way. Could we close this PR and discuss which solution to use on #4470 instead, or does this need to go in sooner?

We were going to initially do that, but with Samuel being OOO we wanted to ensure that this'd be in the next release. I'm open to using that PR if we can be sure it'll go out in the next release, but product decided we should play it safe with a smaller bugfix PR.

[mrbbot]

Fair enough. Considering Samuel's out this week, let's go with this PR. Added a couple comments, but looks good. 👍