Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #4691

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Version Packages #4691

merged 1 commit into from
Jan 4, 2024

Conversation

workers-devprod
Copy link
Contributor

@workers-devprod workers-devprod commented Jan 3, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

create-cloudflare@2.9.0

Minor Changes

Patch Changes

miniflare@3.20231218.1

Patch Changes

  • #4630 037de5ec Thanks @petebacondarwin! - fix: ensure User Worker gets the correct Host header in wrangler dev local mode

    Some full-stack frameworks, such as Next.js, check that the Host header for a server
    side action request matches the host where the application is expected to run.

    In wrangler dev we have a Proxy Worker in between the browser and the actual User Worker.
    This Proxy Worker is forwarding on the request from the browser, but then the actual User
    Worker is running on a different host:port combination than that which the browser thinks
    it should be on. This was causing the framework to think the request is malicious and blocking
    it.

    Now we update the request's Host header to that passed from the Proxy Worker in a custom MF-Original-Url
    header, but only do this if the request also contains a shared secret between the Proxy Worker
    and User Worker, which is passed via the MF-Proxy-Shared-Secret header. This last feature is to
    prevent a malicious website from faking the Host header in a request directly to the User Worker.

    Fixes [🐛 Bug]: Server actions don't work with wrangler pages dev next-on-pages#588

@cloudflare/pages-shared@0.11.6

Patch Changes

  • Updated dependencies [037de5ec]:
    • miniflare@3.20231218.1

wrangler@3.22.3

Patch Changes

  • #4693 93e88c43 Thanks @mrbbot! - fix: ensure wrangler dev exits with code 0 on clean exit

    Previously, wrangler dev would exit with a non-zero exit code when pressing CTRL+C or x. This change ensures wrangler exits with code 0 in these cases.

  • #4630 037de5ec Thanks @petebacondarwin! - fix: ensure User Worker gets the correct Host header in wrangler dev local mode

    Some full-stack frameworks, such as Next.js, check that the Host header for a server
    side action request matches the host where the application is expected to run.

    In wrangler dev we have a Proxy Worker in between the browser and the actual User Worker.
    This Proxy Worker is forwarding on the request from the browser, but then the actual User
    Worker is running on a different host:port combination than that which the browser thinks
    it should be on. This was causing the framework to think the request is malicious and blocking
    it.

    Now we update the request's Host header to that passed from the Proxy Worker in a custom MF-Original-Url
    header, but only do this if the request also contains a shared secret between the Proxy Worker
    and User Worker, which is passed via the MF-Proxy-Shared-Secret header. This last feature is to
    prevent a malicious website from faking the Host header in a request directly to the User Worker.

    Fixes [🐛 Bug]: Server actions don't work with wrangler pages dev next-on-pages#588

  • #4695 0f8a03c0 Thanks @mrbbot! - fix: ensure API failures without additional messages logged correctly

  • #4693 93e88c43 Thanks @mrbbot! - fix: ensure wrangler pages dev exits cleanly

    Previously, pressing CTRL+C or x when running wrangler pages dev wouldn't actually exit wrangler. You'd need to press CTRL+C a second time to exit the process. This change ensures wrangler exits the first time.

  • #4696 624084c4 Thanks @mrbbot! - fix: include additional modules in largest dependencies warning

    If your Worker fails to deploy because it's too large, Wrangler will display of list of your Worker's largest dependencies. Previously, this just included JavaScript dependencies. This change ensures additional module dependencies (e.g. WebAssembly, text blobs, etc.) are included when computing this list.

  • Updated dependencies [037de5ec]:

    • miniflare@3.20231218.1

@workers-devprod workers-devprod requested a review from a team as a code owner January 3, 2024 11:13
Copy link
Contributor

github-actions bot commented Jan 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7412431000/npm-package-wrangler-4691

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7412431000/npm-package-wrangler-4691

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7412431000/npm-package-wrangler-4691 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7412431000/npm-package-miniflare-4691
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7412431000/npm-package-cloudflare-pages-shared-4691
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7412431000/npm-package-create-cloudflare-4691 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.22.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.1
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93e88c4) 75.58% compared to head (009d8cd) 75.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4691      +/-   ##
==========================================
+ Coverage   75.58%   75.64%   +0.05%     
==========================================
  Files         243      243              
  Lines       13096    13096              
  Branches     3375     3375              
==========================================
+ Hits         9899     9906       +7     
+ Misses       3197     3190       -7     

see 6 files with indirect coverage changes

@workers-devprod workers-devprod requested review from a team as code owners January 3, 2024 12:32
@workers-devprod workers-devprod force-pushed the changeset-release/main branch 3 times, most recently from 433d91d to 8d99a34 Compare January 4, 2024 16:12
@lrapoport-cf lrapoport-cf merged commit c2c35a5 into main Jan 4, 2024
28 checks passed
@lrapoport-cf lrapoport-cf deleted the changeset-release/main branch January 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Server actions don't work with wrangler pages dev
5 participants