-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented preserve_file_names config #4742
Conversation
🦋 Changeset detectedLatest commit: 4df213f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-wrangler-4742 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4742/npm-package-wrangler-4742 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-wrangler-4742 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-create-cloudflare-4742 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-cloudflare-kv-asset-handler-4742 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-miniflare-4742 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-cloudflare-pages-shared-4742 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8019695860/npm-package-cloudflare-vitest-pool-workers-4742 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Needs some formatting fixes, it seems. |
Thanks for adding this! It would be great to see some tests around this behaviour, if possible |
hi @benycodes :) can you please fix the formatting and add tests per @petebacondarwin and @penalosa 's comments above? else we'll close the PR until you're able to revisit. thanks! |
Checking with @admah whether this is something we want to take on and get across the finish line ourselves. |
Formatting issues should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests added
Thanks for fixing the formatting and adding tests. |
Added the preserveFileNames option to legacy rules
Added option config.preserve_file_names to moduleCollector
30de433
to
fbd7d5c
Compare
There was actually a small bug in the filename processing, I think I have fixed it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4742 +/- ##
==========================================
+ Coverage 70.33% 70.37% +0.04%
==========================================
Files 298 298
Lines 15512 15515 +3
Branches 3983 3987 +4
==========================================
+ Hits 10910 10919 +9
+ Misses 4602 4596 -6
|
Fixes #4741
preserveFileNames in createModuleCollector
Author has addressed the following: