Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wrangler] test: fix E2E tests #4907

Merged
merged 24 commits into from
Feb 6, 2024
Merged

[wrangler] test: fix E2E tests #4907

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a4215e9
ci: ensure E2E tests failures not reported as successes
mrbbot Feb 2, 2024
f532eb8
test: remove redundant `deploy.test.ts` E2E test
mrbbot Feb 2, 2024
2283d81
test: remove standard pricing warning from E2E test output
mrbbot Feb 2, 2024
c6e3dde
test: update format of writing logs message in E2E tests
mrbbot Feb 2, 2024
9de08d7
test: use `fallback` instead of `default` in E2E tests
mrbbot Feb 2, 2024
970d659
fix: ensure `--log-level` argument applied immediately
mrbbot Feb 2, 2024
bc423c9
test: improve reliability of `dev.test.ts` E2E test
mrbbot Feb 2, 2024
bef4ac4
fix: throw `UserError`s for R2 object/bucket not-found errors
mrbbot Feb 2, 2024
47f1f0c
global install
penalosa Feb 5, 2024
6fae44d
Ensure internal workers listen on ipv4 only
penalosa Feb 5, 2024
57480ea
shorter timeouts
penalosa Feb 5, 2024
d9a3654
lock
penalosa Feb 5, 2024
f6e8616
lockfile
penalosa Feb 5, 2024
00eaa3f
[squash] r2
penalosa Feb 5, 2024
e8bb9b3
[squash] r2 logging
penalosa Feb 5, 2024
92c88f6
ls
penalosa Feb 5, 2024
1164b08
windows
penalosa Feb 5, 2024
81b9762
all tests
penalosa Feb 5, 2024
d2390dc
dev
penalosa Feb 5, 2024
63ab5e5
only
penalosa Feb 6, 2024
0a22759
devalue
penalosa Feb 6, 2024
cc604b0
log
penalosa Feb 6, 2024
ce4a7f8
logging
penalosa Feb 6, 2024
98e1bd5
Cleanup
penalosa Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/wrangler/src/dev.tsx
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Lekensteyn

We had to fix this because checking via localhost for port 9229 could say that it was available twice - once for 127.0.0.1 and again for ::1, which mean that we ended up with two Wrangler sessions that both tried to start workerd on 127.0.0.1:9229; the second of which would fail.

Original file line number Diff line number Diff line change
Expand Up @@ -712,13 +712,13 @@ async function validateDevServerSettings(
const initialIp = args.ip || config.dev.ip;
const initialIpListenCheck = initialIp === "*" ? "0.0.0.0" : initialIp;
const getLocalPort = memoizeGetPort(DEFAULT_LOCAL_PORT, initialIpListenCheck);
const getInspectorPort = memoizeGetPort(DEFAULT_INSPECTOR_PORT, "localhost");
const getInspectorPort = memoizeGetPort(DEFAULT_INSPECTOR_PORT, "127.0.0.1");

// Our inspector proxy server will be binding to the result of
// `getInspectorPort`. If we attempted to bind workerd to the same inspector
// port, we'd get a port already in use error. Therefore, generate a new port
// for our runtime to bind its inspector service to.
const getRuntimeInspectorPort = memoizeGetPort(0, "localhost");
const getRuntimeInspectorPort = memoizeGetPort(0, "127.0.0.1");

if (config.services && config.services.length > 0) {
logger.warn(
Expand Down
Loading