Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a
cf
field to thegetBindingsProxy
result #4926add a
cf
field to thegetBindingsProxy
result #4926Changes from 1 commit
f743084
a2497b8
6bb6eee
091db66
20037dc
2784cd2
fdc5b2f
97afdf5
9ab96ed
fb1421b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: I wanted to use
IncomingRequestCfProperties
here but I've been having issues with the@microsoft/api-extractor
package (it seems not to cope withworkers-types
for some reason 😕)I would go with this simple type for now and look into improving the types later on (also as I want to get proper types for #4792 anyways)
But I don't mind spending more time investigating the
api-extractor
problem for this PR if that's preferred 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about we make this
Record<string, string>
initially and later replace it withIncomingRequestCfProperties
? That way you'll be widening the type which is a non-breaking change.If you go with
any
, you'll be forced to narrow the type in the future which is breaking.