Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Nuxt template dev improvements #4996

Merged
merged 9 commits into from
Feb 13, 2024
Merged

C3: Nuxt template dev improvements #4996

merged 9 commits into from
Feb 13, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Feb 11, 2024

What this PR solves / how to test:

Updates the nuxt template to use the nitro-cloudflare-dev nitro module (which leverages getBindingsProxy) to enable users to run the native nuxt dev command instead of using wrangler paves dev on build output.

Also adds empty wrangler.toml files to the nuxt template, as well as the qwik template which was recently changed in a similar way: https://github.com/cloudflare/workers-sdk/pull/4927/files

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team as a code owner February 11, 2024 23:24
Copy link

changeset-bot bot commented Feb 11, 2024

🦋 Changeset detected

Latest commit: f26526f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 11, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-wrangler-4996

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4996/npm-package-wrangler-4996

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-wrangler-4996 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-create-cloudflare-4996 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-cloudflare-kv-asset-handler-4996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-miniflare-4996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-cloudflare-pages-shared-4996

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.1
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7ccc85) 70.45% compared to head (f26526f) 70.50%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4996      +/-   ##
==========================================
+ Coverage   70.45%   70.50%   +0.05%     
==========================================
  Files         295      295              
  Lines       15411    15411              
  Branches     3948     3948              
==========================================
+ Hits        10858    10866       +8     
+ Misses       4553     4545       -8     

see 6 files with indirect coverage changes

@petebacondarwin
Copy link
Contributor

Seems to be a number of failures in CI?

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 (besides the CI failures as Pete mentioned :P)

(I just left a few minor comments)

.changeset/slimy-apples-reply.md Outdated Show resolved Hide resolved
.changeset/slimy-apples-reply.md Show resolved Hide resolved
@jculvey jculvey merged commit 246512c into main Feb 13, 2024
22 checks passed
@jculvey jculvey deleted the c3-nuxt-bindings branch February 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants