-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: Nuxt template dev improvements #4996
Conversation
🦋 Changeset detectedLatest commit: f26526f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-wrangler-4996 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4996/npm-package-wrangler-4996 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-wrangler-4996 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-create-cloudflare-4996 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-cloudflare-kv-asset-handler-4996 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-miniflare-4996 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7882203860/npm-package-cloudflare-pages-shared-4996 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
==========================================
+ Coverage 70.45% 70.50% +0.05%
==========================================
Files 295 295
Lines 15411 15411
Branches 3948 3948
==========================================
+ Hits 10858 10866 +8
+ Misses 4553 4545 -8 |
Seems to be a number of failures in CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂 (besides the CI failures as Pete mentioned :P)
(I just left a few minor comments)
What this PR solves / how to test:
Updates the nuxt template to use the
nitro-cloudflare-dev
nitro module (which leveragesgetBindingsProxy
) to enable users to run the native nuxt dev command instead of usingwrangler paves dev
on build output.Also adds empty
wrangler.toml
files to the nuxt template, as well as the qwik template which was recently changed in a similar way: https://github.com/cloudflare/workers-sdk/pull/4927/filesAuthor has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.