-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename getBindingsProxy
to getPlatformProxy
#5002
Conversation
🦋 Changeset detectedLatest commit: 110dc12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-wrangler-5002 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5002/npm-package-wrangler-5002 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-wrangler-5002 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-create-cloudflare-5002 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-cloudflare-kv-asset-handler-5002 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-miniflare-5002 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-cloudflare-pages-shared-5002 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
a05c31b
to
85a0dc0
Compare
85a0dc0
to
110dc12
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
==========================================
- Coverage 70.45% 70.44% -0.02%
==========================================
Files 295 297 +2
Lines 15411 15419 +8
Branches 3948 3949 +1
==========================================
+ Hits 10858 10862 +4
- Misses 4553 4557 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! And a docs PR too!
Can you create a PR to remove the deprecated API in Wrangler 4.0.0 and add it to the v4 milestone?
What this PR solves / how to test:
initially
getBindingsProxy
was supposed to only provide proxies for bindings,the utility has however grown, including now
cf
,ctx
andcaches
, toclarify the increased scope the utility is getting renamed to
getPlatformProxy
and its
bindings
field is getting renamedenv
note:
getBindingProxy
with its signature is still kept available, making thisa non breaking change
Author has addressed the following:
getBindingsProxy
documentation togetPlatformProxy
cloudflare-docs#12957Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.