Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename getBindingsProxy to getPlatformProxy #5002

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

dario-piotrowicz
Copy link
Member

What this PR solves / how to test:

initially getBindingsProxy was supposed to only provide proxies for bindings,
the utility has however grown, including now cf, ctx and caches, to
clarify the increased scope the utility is getting renamed to getPlatformProxy
and its bindings field is getting renamed env

note: getBindingProxy with its signature is still kept available, making this
a non breaking change

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 13, 2024 10:44
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 110dc12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-wrangler-5002

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5002/npm-package-wrangler-5002

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-wrangler-5002 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-create-cloudflare-5002 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-cloudflare-kv-asset-handler-5002
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-miniflare-5002
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7885438473/npm-package-cloudflare-pages-shared-5002

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.1
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7ad8ddd) 70.45% compared to head (110dc12) 70.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5002      +/-   ##
==========================================
- Coverage   70.45%   70.44%   -0.02%     
==========================================
  Files         295      297       +2     
  Lines       15411    15419       +8     
  Branches     3948     3949       +1     
==========================================
+ Hits        10858    10862       +4     
- Misses       4553     4557       +4     
Files Coverage Δ
.../wrangler/src/api/integrations/deprecated/index.ts 100.00% <100.00%> (ø)
packages/wrangler/src/api/integrations/index.ts 100.00% <100.00%> (ø)
...s/wrangler/src/api/integrations/platform/caches.ts 8.33% <ø> (ø)
.../src/api/integrations/platform/executionContext.ts 33.33% <ø> (ø)
...wrangler/src/api/integrations/platform/services.ts 7.50% <ø> (ø)
...es/wrangler/src/api/integrations/platform/index.ts 20.45% <0.00%> (ø)
...rc/api/integrations/deprecated/getBindingsProxy.ts 16.66% <16.66%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And a docs PR too!
Can you create a PR to remove the deprecated API in Wrangler 4.0.0 and add it to the v4 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants