-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] fix: don't suggest reporting UserError
s to GitHub
#5030
Conversation
🦋 Changeset detectedLatest commit: 4fcf159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-wrangler-5030 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5030/npm-package-wrangler-5030 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-wrangler-5030 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-create-cloudflare-5030 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-cloudflare-kv-asset-handler-5030 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-miniflare-5030 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7930056975/npm-package-cloudflare-pages-shared-5030 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
+ Coverage 70.42% 70.46% +0.03%
==========================================
Files 297 297
Lines 15425 15424 -1
Branches 3952 3951 -1
==========================================
+ Hits 10863 10868 +5
+ Misses 4562 4556 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Fixes #3867.
What this PR solves / how to test:
I tried to reproduce #3867 by updating my
.wrangler/config/default.toml
with an access token expiry in the past, and an invalid refresh token, butwrangler whaomi
just opened a browser and prompted me to login. It's possible this specific issue was fixed in another PR. 🤔 Either way, given the recent work to split outUserError
s, of which theNot logged in.
error seen here is one, it seemed like a good idea to hide the bug reporting message in these cases.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.