Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miniflare] chore: add missing miniflare changeset for workerd bump #5068

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Feb 21, 2024

What this PR solves / how to test:

The Version Packages PR is currently a little broken. We think this is because the miniflare packages has changes without a corresponding changeset. This PR adds the missing changeset, which we should've included anyways.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: adding a changeset
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: adding a changeset

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 180efd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-wrangler-5068

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5068/npm-package-wrangler-5068

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-wrangler-5068 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-create-cloudflare-5068 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-cloudflare-kv-asset-handler-5068
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-miniflare-5068
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-cloudflare-pages-shared-5068
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7988541032/npm-package-cloudflare-vitest-pool-workers-5068

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.4 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.3
workerd 1.20240208.0 1.20240208.0
workerd --version 1.20240208.0 2024-02-08

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c46028) 70.27% compared to head (180efd8) 70.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5068      +/-   ##
==========================================
+ Coverage   70.27%   70.31%   +0.03%     
==========================================
  Files         298      298              
  Lines       15481    15481              
  Branches     3971     3971              
==========================================
+ Hits        10879    10885       +6     
+ Misses       4602     4596       -6     

see 6 files with indirect coverage changes

@mrbbot mrbbot merged commit b03db86 into main Feb 21, 2024
17 checks passed
@mrbbot mrbbot deleted the bcoll/missing-miniflare-changeset branch February 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants