Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate duplicate bindings across all binding types #5737

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented May 1, 2024

What this PR solves / how to test

Fixes #2893

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Tests not necessary because: behaviour already tested, this PR just adds it to more bindings (and adds a type level to check to make sure this doesn't regress)
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@penalosa penalosa requested a review from a team as a code owner May 1, 2024 17:29
Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: cc87ccd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5737/npm-package-wrangler-5737

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-create-cloudflare-5737 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-kv-asset-handler-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-miniflare-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-pages-shared-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-vitest-pool-workers-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-editor-shared-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-shared-5737

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa force-pushed the 2893-bug-same-name-for-the-kv-and-queue-bindings-generates-internal-server-error-10002 branch from 11deac5 to cd5eb7a Compare May 1, 2024 17:33
@penalosa penalosa closed this May 13, 2024
@penalosa penalosa reopened this May 13, 2024
@CarmenPopoviciu
Copy link
Contributor

this LGTM. Left a small comment + don't forget about adding a changeset. Otherwise, good to go

@CarmenPopoviciu
Copy link
Contributor

@penalosa do we still want to land this?

@petebacondarwin petebacondarwin marked this pull request as draft July 24, 2024 15:05
@penalosa penalosa force-pushed the 2893-bug-same-name-for-the-kv-and-queue-bindings-generates-internal-server-error-10002 branch from cd5eb7a to 884210f Compare October 21, 2024 11:53
@penalosa penalosa force-pushed the 2893-bug-same-name-for-the-kv-and-queue-bindings-generates-internal-server-error-10002 branch from cdf0ade to a320c3b Compare October 21, 2024 12:58
@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Oct 21, 2024
@penalosa penalosa marked this pull request as ready for review October 21, 2024 17:28
@penalosa penalosa merged commit 9bf51d6 into main Oct 22, 2024
20 checks passed
@penalosa penalosa deleted the 2893-bug-same-name-for-the-kv-and-queue-bindings-generates-internal-server-error-10002 branch October 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: same name for the KV and Queue bindings generates internal server error (10002)
3 participants